Skip to content

CrostonModel #1317

Open
Mr-Geekman opened this issue Jul 17, 2023 · 0 comments
Open

CrostonModel #1317

Mr-Geekman opened this issue Jul 17, 2023 · 0 comments
Labels
enhancement New feature or request priority/medium Medium priority task

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Jul 17, 2023

🚀 Feature Request

Add model based on Croston's method for intermittent demand.

We could also try to implement some variations of this method.

Proposal

Add CrostonModel.

  • It could be implemeted as per-segment model using BaseAdapter and PerSegmentModelMixin (look at ProphetModel for reference)
  • It could be implemented as NonPredictionIntervalContextIgnorantAbstractModel that saves the answer during the fit
  • During fit it should raise a warning that it doesn't work with exogenous features, look at SeasonalMovingAverageModel

References:

To discuss:

  • Should it be our own implementation or some external package can be used (statsforecast for example)
    • We should try to make our own implementation

Test cases

  • Tests for the model itself
  • Inference tests in tests/test_models/test_inference/.

Additional context

No response

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Jul 17, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Jul 17, 2023
@Mr-Geekman Mr-Geekman added the priority/medium Medium priority task label Jul 17, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority/medium Medium priority task
Projects
Status: Todo
Development

No branches or pull requests

1 participant