You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you create a msgp Reader using msgp.NewReader(), it will acquire a reader from the readerPool but there's no way to return it - freeR() is unexported, as is the pool.
The text was updated successfully, but these errors were encountered:
@peterbourgon I don't see how this is a "major bug;" it looks like a missing optimization at worst.
The pool doesn't retain a reference to the reader, so it is simply GC'd as normal, unless you've noticed something that I haven't.
You're right, I mis-remembered how sync.Pool worked; I thought it retained references to leased objects. Forgive the alarm. I still believe this is a major bug.
If you create a msgp Reader using
msgp.NewReader()
, it will acquire a reader from thereaderPool
but there's no way to return it -freeR()
is unexported, as is the pool.The text was updated successfully, but these errors were encountered: