Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Setting accessibilityLabel to testID in production is not a good idea #1

Open
LeoNatan opened this issue Sep 26, 2017 · 13 comments
Open

Comments

@LeoNatan
Copy link

accessibilityLabel is used by the iOS system to help handicapped users. For instance, Voice Over uses this.

If you set some testing value to this, your handicapped users will suffer.

@LeoNatan
Copy link
Author

Differentiate accessibilityIdentifier and accessibilityLabel.

@isnifer
Copy link
Contributor

isnifer commented Sep 26, 2017

@LeoNatan look into the code. I'm using testID for iOS.

@LeoNatan
Copy link
Author

On Android it’s exactly the same problem:
https://developer.android.com/training/accessibility/accessible-app.html

@LeoNatan
Copy link
Author

Google TalkBack uses that to read the content description to the user. Exactly the same as Voice Over on iOS.

@isnifer
Copy link
Contributor

isnifer commented Sep 26, 2017

@LeoNatan sadly, but Appium does not work otherwise

@LeoNatan
Copy link
Author

Then fix Appium. Disabled users should not suffer because some test framework is buggy. Sorry

@isnifer
Copy link
Contributor

isnifer commented Sep 26, 2017

@LeoNatan yes, of course

@isnifer
Copy link
Contributor

isnifer commented Sep 26, 2017

@LeoNatan we are using Appium until Detox doesn't work with it like with iOS :)

@LeoNatan
Copy link
Author

It is being worked on actively.

@simonracz
Copy link

Just a side note: Detox Android works with test id already.

Appium can't see test ids, because they are transferred to view tags on Android. (You probably know about this.)
View tags are not accessible for UIAutomator, on which Appium depends on.

@isnifer
Copy link
Contributor

isnifer commented Sep 28, 2017

@simonracz yes, I know. Thank you.
If I understand correctly I need only testID for both platforms if I will use detox only, yes?

@LeoNatan
Copy link
Author

Yes, that is the best way to test. byText is not optimal because if you localization, it will fail your test.

@isnifer
Copy link
Contributor

isnifer commented Sep 29, 2017

@LeoNatan good to know. So, for now, we are using Appium only to check Auth via Twitter and FB, also to test Apple Pay, cause EarlGrey can't do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants