You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Those should be changed to have assert statements, or numpy.testing.assert_allclose for floating point numbers.
Plotting tests should either be removed or moved into a separate test function. E.g. the test in test_lhd.py currently is skipped in continuous integration because the scatterplot_matrix package isn't available:
Currently most of the tests just have print statements at the end:
https://github.com/tisimst/mcerp/blob/master/mcerp/tests/
Those should be changed to have assert statements, or
numpy.testing.assert_allclose
for floating point numbers.Plotting tests should either be removed or moved into a separate test function. E.g. the test in
test_lhd.py
currently is skipped in continuous integration because thescatterplot_matrix
package isn't available:mcerp/mcerp/tests/test_lhd.py
Line 31 in 2bb8260
I can't find
scatterplot_matrix
on PyPI. @tisimst - Could you please comment what / where this is? Should it be added or that plotting test removed?The text was updated successfully, but these errors were encountered: