Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asserts to tests #19

Open
cdeil opened this issue Jan 9, 2019 · 0 comments
Open

Add asserts to tests #19

cdeil opened this issue Jan 9, 2019 · 0 comments
Milestone

Comments

@cdeil
Copy link
Collaborator

cdeil commented Jan 9, 2019

Currently most of the tests just have print statements at the end:
https://github.com/tisimst/mcerp/blob/master/mcerp/tests/

Those should be changed to have assert statements, or numpy.testing.assert_allclose for floating point numbers.

Plotting tests should either be removed or moved into a separate test function. E.g. the test in test_lhd.py currently is skipped in continuous integration because the scatterplot_matrix package isn't available:

from scatterplot_matrix import scatterplot_matrix as spm

I can't find scatterplot_matrix on PyPI. @tisimst - Could you please comment what / where this is? Should it be added or that plotting test removed?

@cdeil cdeil added this to the 0.13 milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant