Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable length values must be audited for safety #5

Open
taoeffect opened this issue Apr 17, 2014 · 1 comment
Open

variable length values must be audited for safety #5

taoeffect opened this issue Apr 17, 2014 · 1 comment

Comments

@taoeffect
Copy link
Collaborator

Any variable length-type variable provided by the input data must be:

  • bounds checked and properly handled. comments about all possibilities and resolutions needed.
  • highlighted in the code clearly through gratuitous comments (equivalent of yellow police caution tape. caps-lock welcome!)
  • special consideration for Denial-of-Service attacks needed.

Comments also needed in Packet.parse and Packet.write that state what the buffer size is (for TCP and UDP).

A regex search for len.*= could help find them.

@taoeffect
Copy link
Collaborator Author

Also, for TCP servers, where's the async nature of the server? All this packet parsing seems synchronous, so how are gigantic messages handled without taking down the server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant