-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no space for new pane with main-horizontal and a few panes #800
Comments
Ok it just happened again with a hand-made layout:
|
@categulario Can you give a screenshot of this? perhaps a video recording? (mp4 and webm work on github now) |
Here it is vokoscreenNG-2022-08-26_18-58-32.recortado.mp4 |
@categulario This is an interesting one. Makes sense that the screen would run out Start a I suppose a few things we could try is:
Another thing is we could make it so individual pane commands could control how they're split in greater detail (and explicitly choose to |
I'm experiencing possibly the same issue with a custom layout. Some additional data points: What I notice in the error message is that it seems to detect It seems to me that the addition of a default size of 80x24 in #793 might have caused this. The layout string (at least for these custom layouts) includes the required window size. Maybe that can be used instead of a default size? Or the minimum required size could be pre-calculated from the layout string (and the number of panes in the window)? Let me know if I can provide more information. |
@jgottfried Thank you for this feedback as well
This is the particular area of code in question I think would be of conflict (as you said, from #793): v1.13.0...v1.13.1#diff-9316655a97cbe443559ee45c1b1fa26bfa86e314210653806ce215702a956931R221-L425
@jgottfried If you had a video of the behavior in 1.13.0 vs 1.13.1, that'd be a dream. Also, does this look like a fair YAML representation of it? ---
session_name: main
windows:
- layout: c1bd,150x74,0,0,0
panes:
- shell_command: top
start_directory: "~"
window_name: top
- focus: 'true'
start_directory: "~/Projects/flask-project"
layout: 5313,150x74,0,0[150x2,0,0,1,150x17,0,3{75x17,0,3,2,74x17,76,3,3},150x17,0,21,4,150x17,0,39,5,150x17,0,57,6]
options:
automatic-rename: 'off'
panes:
- shell_command:
- echo celery
- shell_command:
- echo gunicorn
- shell_command:
- echo monitoring
- shell_command:
- echo python
- shell_command:
- echo process
- focus: 'true'
shell_command:
- echo flask shell
window_name: flask-project
- layout: c1c4,150x74,0,0,7
options: {}
panes:
- shell_command:
start_directory: "~"
window_name: misc
@categulario @jgottfried What if we allowed |
2022-08-28.19-12-46.mp4Video shows the configuration file, it working in v1.13.0, upgrade to 1.13.1, the error message, downgrade to 1.13.0 and it working again.
That could work. It might even be necessary for the even spacing layouts. And if that is the quickest way to fix this issue, that would be great. [Edited to make preview show] |
@jgottfried Thank you very much! (you can add a newline before your .mp4 file and it'll show a video preview by the way) |
Here is the issue Right now: In 1.13.1, we set a default size, but we also moved around calls to What I propose is:
|
|
Nope
sometimes |
I am seeing the same bug w |
I am having same issue
I did not had any ~/.tmux.conf had to create from tmux show -g | > location it have default size as 80x24 changed it didn't helped. removed it didn't helped Tried Tiled, main-horizontal, custom Tmux file:
|
I was getting a very similar (identical?) error... ...but now that I have an existing session running, these
as well as my other more complex Are other people experiencing this issue only when there are no existing tmux sessions? |
Can you please tell me. what do you mean by existing session? |
do If no sessions exist, doing Do you follow? So... If you have no sessions running at all, then do If so... that should narrow down "when" this problem occurs... I think... maybe? |
PS:
When tmux is running and you're using or "attached" to it, you're in a tmux "session" :) |
its tmuxp 1.31.1 libtmux 0.14.2 |
Oh yeah, version numbers, always important...
|
no it does not work :( |
For the moment the workaround is:
If I write a "fix" - I use quotes because the behavior is undefined as of now [1]😆 - I will need to take time to write tests myself and ensure old behavior isn't broken. PRs are welcome in the mean time [1] And if I define behavior, we need find a way to satisfy valid, common usage cases in a good way. |
P.S. In the background, I am taking time to improve our test infrastructure to make sure issues like this don't happen again. |
@ahillio I believe that's why it happens. The tmux server's dimensions are small in 1.13.1, since it'll only be 80x24 until your client connects to tmux. (This is how I believe it works, I would need to look closer at I will try to release a patch / PR tomorrow for the thread to test And thank you for the details and the libtmux / tmux version in here (re: #800 (comment)) @Haider-Ali-DS Welcome Haider! Thanks for the details confirming it is v1.13.1 as well (re: #800 (comment)). If you are around this weekend I will release a new version of tmuxp for the thread to test |
re: #800 (comment) Can you try to run |
Oh... actually... I'm experiencing this when there are existing sessions already. I'm not sure what caused it to work previously but now detaching from my session and running |
|
Oh interesting! Switching back to |
@ApexWeed in re: #806 (comment) / #806, this is the main thread for the issue I think yours duplicates |
@ahillio @Haider-Ali-DS @categulario @jgottfried Using v1.13.1, If you add an e.g. # the rest of your config
options:
default-size: 800x600 or # the rest of your config
global_options:
default-size: 800x600 |
Yes…
and |
@ahillio Thank you! I will release a patch for this.
Yes you can trust |
yes, thank you it showed no error this time. |
Step 1: Provide a summary of your problem
I created a yaml config with five panes in layout main-horizontal (although main-vertical also breaks). When I tried to run it it failed with the following exception:
Step 2: Provide tmuxp details
debug-info
also my console window is 213x51
Step 3: Describe the problem:
layout is not loaded, session is partially formed but not attached, exception is thrown.
Steps to reproduce:
I created this minimal config file that reproduces the issue:
Observed Results:
A python exception
Expected Results:
A nicely built main-horizontal layout
Thoughts
Of course if I build the layout by hand it works, because I'm a human and I know that if I split the same pane over and over again, since every new pane is half the size of the previous one then soon my panes will be too small. So I resize them a little bit before splitting again, then adjust the final size.
Perhaps the algorithm for building the layout could do that. I think it is possible to know the final size of everything just from the layout, the amount of panes and the window size.
The text was updated successfully, but these errors were encountered: