Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client exception should serialize errors #34

Open
Rast1234 opened this issue Apr 1, 2021 · 0 comments
Open

Client exception should serialize errors #34

Rast1234 opened this issue Apr 1, 2021 · 0 comments
Labels
client

Comments

@Rast1234
Copy link
Member

Rast1234 commented Apr 1, 2021

  • add serialized error to context
  • limit size to about 5kb

Pass serializer here:

Tochka.JsonRpc/src/Tochka.JsonRpc.Client/Models/SingleJsonRpcResult.cs

Line 42 in 24d8ee0

context.WithError(untypedErrorResponse.Error);

Do something like ErrorInfo = JToken.FromObject(data, serializer.Serializer); and limit its length

Use this in ToString instead of Error property
@Rast1234 Rast1234 added the client label Apr 1, 2021
@Rast1234 Rast1234 mentioned this issue Apr 1, 2021
Open
Rast1234 pushed a commit that referenced this issue May 12, 2021
@Fringle
Feature/log content and error (#50)
06d5f40 
fix(client): better error handling, #34 #36 

* add setting error in context
* fix client tests

Authored-by: Dmitriy Belokobylskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rast1234