Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check what usage of "get_callable_run_method" we need and what to eliminate #52

Open
ca11mejane opened this issue Sep 11, 2024 · 0 comments

Comments

@ca11mejane
Copy link
Collaborator

ca11mejane commented Sep 11, 2024

Because I removed the RUN_METHOD_ALIAS constant, there is a question of which functions/methods we need to keep and what to get rid of.

need to decide on these usages:

  1. method = get_callable_run_method(self._node_map[source])
  2. if inspect.iscoroutinefunction(get_callable_run_method(node)):

I still have a question for this method. If we remove the ability to use different names in subclasses, I guess that we actually don't need to remain logic with a method's name as a string. We can just leave the abstract method "process" and use it. It will help understand codebase much faster and less painfully because the method is more explicit than the string name of the method

Originally posted by @Moootya in #33 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant