Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a plugin mechanism for core/rpc/storage #508

Open
darkskygit opened this issue Aug 14, 2023 · 0 comments
Open

provide a plugin mechanism for core/rpc/storage #508

darkskygit opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
mod:base Related to base module(jwst) mod:libs Related to the libs mod:storage Related to storage module(jwst-storage) mod:sync Related to sync module(jwst-rpc) Refactor story Features perceivable by end-users

Comments

@darkskygit
Copy link
Member

darkskygit commented Aug 14, 2023

currently we have the following features coupled in core/rpc/storage:

  • core: full text indexing, single page extract
  • rpc: websocket/webrtc connector
  • storage: image minify, stream storage, database/s3 support

these features need to introduce additional dependencies, making testing and compiling time longer

at present, cargo features are used to switch these functions, which requires us to include a lot of conditional judgments in the code, and making the code difficult to maintain

therefore, we need to design a plugin mechanism to make these features pluggable, which makes the code easier to maintain and facilitates external developers easily to develop new functions

@darkskygit darkskygit added mod:libs Related to the libs story Features perceivable by end-users mod:sync Related to sync module(jwst-rpc) mod:storage Related to storage module(jwst-storage) mod:base Related to base module(jwst) Refactor labels Aug 14, 2023
@darkskygit darkskygit self-assigned this Aug 14, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in AFFiNE Project Aug 14, 2023
@EYHN EYHN removed this from AFFiNE Project Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:base Related to base module(jwst) mod:libs Related to the libs mod:storage Related to storage module(jwst-storage) mod:sync Related to sync module(jwst-rpc) Refactor story Features perceivable by end-users
Projects
None yet
Development

No branches or pull requests

1 participant