From 4dbfc7add3c514baa4a3f5a989f8ffb4b81a5c72 Mon Sep 17 00:00:00 2001
From: Artem Chumachenko <artek.chumak@gmail.com>
Date: Tue, 8 Oct 2024 18:47:06 +0200
Subject: [PATCH 1/2] Update openapi.yaml for Lora vs Full training

---
 openapi.yaml | 55 +++++++++++++++++++++++++++++++++-------------------
 1 file changed, 35 insertions(+), 20 deletions(-)

diff --git a/openapi.yaml b/openapi.yaml
index 5c992f4..8b9a9df 100644
--- a/openapi.yaml
+++ b/openapi.yaml
@@ -406,26 +406,11 @@ paths:
                 wandb_api_key:
                   type: string
                   description: API key for Weights & Biases integration
-                lora:
-                  type: boolean
-                  description: Whether to enable LoRA training. If not provided, full fine-tuning will be applied.
-                lora_r:
-                  type: integer
-                  default: 8
-                  description: Rank for LoRA adapter weights
-                lora_alpha:
-                  type: integer
-                  default: 8
-                  description: The alpha value for LoRA adapter training.
-                lora_dropout:
-                  type: number
-                  format: float
-                  default: 0.0
-                  description: The dropout probability for Lora layers.
-                lora_trainable_modules:
-                  type: string
-                  default: 'all-linear'
-                  description: A list of LoRA trainable modules, separated by a comma
+                training_type:
+                  type: object
+                  oneOf:
+                    - $ref: '#/components/schemas/FullTrainingType'
+                    - $ref: '#/components/schemas/LoRATrainingType'
       responses:
         '200':
           description: Fine-tuning job initiated successfully
@@ -1971,3 +1956,33 @@ components:
           type: string
         size:
           type: integer
+
+    FullTrainingType:
+      type: object
+      properties:
+        type:
+          type: string
+          enum: ['Full']
+      required:
+        - type
+    LoRATrainingType:
+      type: object
+      properties:
+        type:
+          type: string
+          enum: ['Lora']
+        lora_r:
+          type: integer
+        lora_alpha:
+          type: integer
+        lora_dropout:
+          type: number
+          format: float
+          default: 0.0
+        lora_trainable_modules:
+          type: string
+          default: 'all-linear'
+      required:
+        - type
+        - lora_r
+        - lora_alpha

From d81f54c4e49061500738866184ada5f9cf9b315d Mon Sep 17 00:00:00 2001
From: Artem Chumachenko <artek.chumak@gmail.com>
Date: Tue, 8 Oct 2024 21:20:38 +0200
Subject: [PATCH 2/2] Update openapi.yaml

---
 openapi.yaml | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/openapi.yaml b/openapi.yaml
index 8b9a9df..52e3e50 100644
--- a/openapi.yaml
+++ b/openapi.yaml
@@ -1733,16 +1733,11 @@ components:
           type: number
         eval_steps:
           type: integer
-        lora:
-          type: boolean
-        lora_r:
-          type: integer
-        lora_alpha:
-          type: integer
-        lora_dropout:
-          type: number
-        lora_trainable_modules:
-          type: string
+        training_type:
+          type: object
+          oneOf:
+            - $ref: '#/components/schemas/FullTrainingType'
+            - $ref: '#/components/schemas/LoRATrainingType'
         status:
           $ref: '#/components/schemas/FinetuneJobStatus'
         job_id: