appender: expected a Fn<()> closure, found NonBlocking

[rminderhoud]

Hello all, I'm stuck on a tricky problem and could use some insights. I am using tracing-appender from commit 0114ec1 to get access to the new RollingFileAppender builder. Here is my usage for writing logs to a file and to stdout using two different layers:

    let (non_blocking_file_appender, _guard) = tracing_appender::non_blocking(
        tracing_appender::rolling::Builder::new()
            .rotation(tracing_appender::rolling::Rotation::DAILY)
            .filename_prefix("prefix")
            .filename_suffix("suffx")
            .build(&"./logs")
            .expect("Failed to create file appender"),
    );
    
    let stdout_layer = tracing_subscriber::fmt::layer();
    let file_layer = tracing_subscriber::fmt::layer().with_writer(non_blocking_file_appender);

    let subscriber = tracing_subscriber::registry()
        .with(stdout_layer)
        .with(file_layer);
        
    tracing::subscriber::set_global_default(subscriber).expect("Failed to set default subscriber");

However, layer doesn't seem to like taking NonBlocking as a writer:

error[E0277]: expected a `Fn<()>` closure, found `NonBlocking`
  --> main.rs
   |
162 |     let file_layer = tracing_subscriber::fmt::layer().with_writer(non_blocking_file_appender);
   |                                                       ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an `Fn<()>` closure, found `NonBlocking`
   |                                                       |
   |                                                       required by a bound introduced by this call
   |
   = help: the trait `Fn<()>` is not implemented for `NonBlocking`
   = note: wrap the `NonBlocking` in a closure with no arguments: `|| { /* code */ }`
   = help: the following other types implement trait `MakeWriter<'a>`:
             Arc<W>
             BoxMakeWriter
             OrElse<A, B>
             Tee<A, B>
             TestWriter
             WithFilter<M, F>
             WithMaxLevel<M>
             WithMinLevel<M>
           and 2 others
   = note: required for `NonBlocking` to implement `for<'writer> MakeWriter<'writer>`
note: required by a bound in `tracing_subscriber::fmt::Layer::<S, N, E, W>::with_writer`
  --> C:\Users\Ralph\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tracing-subscriber-0.3.17\src\fmt\fmt_layer.rs:179:13
   |
177 |     pub fn with_writer<W2>(self, make_writer: W2) -> Layer<S, N, E, W2>
   |            ----------- required by a bound in this associated function
178 |     where
179 |         W2: for<'writer> MakeWriter<'writer> + 'static,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Layer::<S, N, E, W>::with_writer`

I only had this issue when I upgraded to a new commit rather than using the published crate so I suspect something must have changed but I'm completed stumped as to what could have? I've read through the code as much as I could and I wasn't able to solve the issue.

[rminderhoud]

Hmm I was able to make it work by passing a closure instead, not sure why that works compared to examples: .with_writer(move || non_blocking_file_appender.clone())