-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Tutorial falls apart in the "channels" section #503
Comments
That is good feedback. You aren't entirely wrong. I think towards the second half, it is more about providing the necessary context to understand the mini-redis code base. One reason for this is that I want to avoid having a to explain adding a bunch of boilerplate. Thoughts? |
Sorry for the delay in responding (health issues). I'm not sure if it is possible, but I would take the Rust documentation as an example. The way their embedded code works is that it is able to display snippets but you still have the option to see the code in its entirety. Maybe having an example repository (if it exists, I definitely missed it) that reflects the tutorial would also help. |
The code from the chapters can be found in the tutorial-code folder. And of course a lot of the code is inspired by the mini-redis codebase. |
After struggling a bit through the tutorial, I agree whit @theogravity . The learning flowLet me explain from my own learning experience. I like to type code in order to learn. So I follow:
Weirdly, the
SuggestionsI am a simple man. I see bash commands, I copy them. We need waaaayyyyy more instructions on organizing the code user-side. I suggest more verbose explanations of the like:
The list of missing instructions:
Now about Framing. I know it's not writen at all but a |
Since MR #565 the Channels and I/O pages are less confusing, but there still should be a mention somewhere that goes like:
Or, way better (but way longer to write), an actual follow-up tutorial on how to build |
I've been following the tutorial and have similar experience. In addition, as a reader/learner, after reading the Setup section, I thought mini-redis would be used as an example throughout the entire tutorial. But starting from the Channel or I/O section, I realized that I had to switch back and forth between mini-redis and some other independent examples, without being explicitly reminded. Maybe this only happened to me, but it feels Edit: The Async in Depth section seems to be repeating what is covered by the async book. |
I was following the tutorial well until I hit the "channels" section. Unlike the previous sections, I'm not exactly sure what file(s) I should be modifying / creating, or where the modifications should be placed. It really starts to become noticeable once I get to the "Spawn manager task" subsection, where I'm not quite sure I should be placing the manager code.
It feels more like a set of examples than a tutorial at this point.
The text was updated successfully, but these errors were encountered: