-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Makerspace Academy] Footer color should be different from previous block color #49
Comments
Hi Tobias, I'm confused regarding this issue. In academy index, the footer takes the bg-neutral-50 to differentiate from the previous block, as your design. But in the modules, the footer is fully white bordering the comment section (which is in a darker shade). Reading your comment in this ticket, is that what you wanted? Because when i inspect figma, in the module section of academy, the comments and footer all share the bg-neutral-50. How do you want me to proceed? |
This is how the website looks like now... Maybe on one of the many updates to the page it got resolved? |
Do you have an example page without comments enabled? I couldn't find any. |
I think there's no layout implemented for academy module with submodules yet, that's why i can't see any example of a page without comments enabled in the academy section. |
At the time of writing this issue, there was an academy module online without comments enabled. In that case, I'd suggest to please manually reproduce this case and fix it, as it might happen to occur in the future when content is added. @pReya? |
When the footer is bordering a white page, its background becomes Neutral-50. If it's bordering a comment section (e.g. in Makerspace Academy), its background becomes Neutral-00 (full white)
The text was updated successfully, but these errors were encountered: