Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makerspace Academy] Footer color should be different from previous block color #49

Open
tobimori opened this issue Oct 31, 2022 · 6 comments
Assignees

Comments

@tobimori
Copy link
Member

CleanShot 2022-10-31 at 16 27 15@2x

CleanShot 2022-10-31 at 16 27 34@2x

When the footer is bordering a white page, its background becomes Neutral-50. If it's bordering a comment section (e.g. in Makerspace Academy), its background becomes Neutral-00 (full white)
@tobimori tobimori changed the title Footer color should be different from previous block color Footer color should be different from previous block color (Makerspace Academy) Oct 31, 2022
@tobimori tobimori changed the title Footer color should be different from previous block color (Makerspace Academy) [Makerspace Academy] Footer color should be different from previous block color Oct 31, 2022
@Agustina-Carrion
Copy link
Member

Hi Tobias, I'm confused regarding this issue. In academy index, the footer takes the bg-neutral-50 to differentiate from the previous block, as your design. But in the modules, the footer is fully white bordering the comment section (which is in a darker shade).

Reading your comment in this ticket, is that what you wanted?

Because when i inspect figma, in the module section of academy, the comments and footer all share the bg-neutral-50.

How do you want me to proceed?

@tobimori
Copy link
Member Author

The footer color should always differ from the previous blocks' color.

This means:

  • If comments are active, the comments have bg-neutral-50, and the footer is fully white.
  • If comments aren't active, the footer has bg-neutral-50, as the previous block (content) is fully white.

This issue was created to address that the footer on Academy pages was always fully white, no matter if the comments are there or not.

The design shows this correctly:
CleanShot 2023-02-15 at 11 11 44@2x
Left with comments has fully white footer, right without comments has bg-neutral-50.

@Agustina-Carrion
Copy link
Member

This is how the website looks like now... Maybe on one of the many updates to the page it got resolved?

@tobimori
Copy link
Member Author

Do you have an example page without comments enabled? I couldn't find any.

@Agustina-Carrion
Copy link
Member

I think there's no layout implemented for academy module with submodules yet, that's why i can't see any example of a page without comments enabled in the academy section.

@tobimori
Copy link
Member Author

tobimori commented Feb 15, 2023

At the time of writing this issue, there was an academy module online without comments enabled. In that case, I'd suggest to please manually reproduce this case and fix it, as it might happen to occur in the future when content is added. @pReya?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants