Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket passed validation but cannot open #2

Open
DerekFangming opened this issue Nov 3, 2018 · 4 comments
Open

Ticket passed validation but cannot open #2

DerekFangming opened this issue Nov 3, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@DerekFangming
Copy link

Hi,
Thanks for the tool. I have code to generate pass and it had been working for a year until last month when my pass certificate expired. I renewed it and now, my code still generates pass without problem, but I can no longer open it, on either my laptop or my phone.
Here are the two files. The working.pkpass is generated on Feb this year and you can open it with wallet on laptop or phone. When I validate this, it shows the expired signature on your website, which is expected. The notWorking.pkpass was generated with renewed certificate. It passes all the validation but just won't open.

Do you know what could go wrong with the new ticket?

Thanks!

@tomasmcguinness
Copy link
Owner

Hello,

I'm happy to take a look, but I don't have permission to access that GDrive share. I have requested permission. I'll review again, once I have access to the passes.

Thanks!

Tom

@tomasmcguinness
Copy link
Owner

Hello - will you be able to provide me with permission?

@DerekFangming
Copy link
Author

DerekFangming commented Nov 15, 2018

Oh hi, sorry for the late reply.

I have fixed it in the pass kit SDK here

If you want to read details, look at the conversation I had with the repo owner here

Basically, the pkpass file cannot have files in it with name starting with a dot. You can do your checkings in your code. However, I suggest you to integrate with apple's default pkpass signer to double check the tickets. It's a C project that can be compiled to executable.

Here's the new link for the not working pkpass for a kick start.

Feel free to close this issue

@tomasmcguinness
Copy link
Owner

Thank you! I'll review and add that check into the validator.

@tomasmcguinness tomasmcguinness added the enhancement New feature or request label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants