Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting margin-bottom on custom typography targets #615

Open
frzsombor opened this issue Jun 10, 2024 · 0 comments · Fixed by #616
Open

Allow setting margin-bottom on custom typography targets #615

frzsombor opened this issue Jun 10, 2024 · 0 comments · Fixed by #616
Labels
feature Features, refactoring, enhancements, improvements triage Awaiting review

Comments

@frzsombor
Copy link
Contributor

Description

Describe your feature request.

As the title says, I would like to set a "margin-bottom" for custom typography selectors too.
The reason is, many times I work with a design, the designer uses H1, H2, etc. STYLES differently, than what is required for good SEO (for example designer uses H3 style where I have to insert an actual H2 tag). For these situations I started using custom selectors for defining Typography defaults like h1, .text-like-h1, h2, .text-like-h2, etc. However, I can not set a margin-bottom, as it is not supported for custom selectors, only a few others. However, this only requires a very simple modification as class-typography.php already handles margin-bottom for all elements.

References

https://github.com/tomusborne/generatepress/blob/3.4.0/src/customizer-controls/font-manager/utils.js#L45-L47
https://github.com/tomusborne/generatepress/blob/3.4.0/inc/class-typography.php#L176-L179

@frzsombor frzsombor added the feature Features, refactoring, enhancements, improvements label Jun 10, 2024
@github-actions github-actions bot added the triage Awaiting review label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features, refactoring, enhancements, improvements triage Awaiting review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant