Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Fireworks Demo Contract Test Suite #360

Closed
reveloper opened this issue Nov 9, 2023 · 6 comments
Closed

Enhance Fireworks Demo Contract Test Suite #360

reveloper opened this issue Nov 9, 2023 · 6 comments
Assignees
Labels
Approved This proposal is approved by the committee Education Related to educational resources or initiatives

Comments

@reveloper
Copy link
Contributor

reveloper commented Nov 9, 2023

Summary

Expansion of the test suite and the smart contract for Fireworks with unique edge cases.

Bounty Context

Why it's Important?
In order to ensure broader use cases are covered and comprehensively explained, it is necessary to include further edge case examples to the Fireworks demo contract. This would allow developers interested in TON Blockchain to gain a deeper understanding of scenarios relating to messages, transactions, fees, and testing themes.

Problem showcase
Currently, the Fireworks demo smart contract and its related test suite do not provide comprehensive coverage of edge cases. Likewise, the inclusion of such cases in the documentation is insufficient, leading to lack of clarity.

Potential Solution

  1. Add logic in the smart contract if required for the edge case demonstration.

  2. Create a unique edge case test in the test suite here. Cover as much as possible TVM Exit Code cases. demonstrating aspects like TVM error exit code or bounced message logic.

  3. Add a clear, concise description of the test case in the TON Documentation, enabling others to understand the rationale and implementation method easily.

References

Fireworks smart contract repository (https://github.com/ton-community/fireworks-func)
TON Documentation (https://docs.ton.org/develop/smart-contracts/testing/writing-test-examples)

REWARD

  • SBT Bounty Reward
  • 1000 USD in TON

🪄 Created with the help of TON Bounties Creator Bot.

@delovoyhomie delovoyhomie added Approved This proposal is approved by the committee Education Related to educational resources or initiatives labels Nov 11, 2023
@reveloper
Copy link
Contributor Author

@mbaneshi Please note, that while you are assigned to bounty, you cannot take on another until you have completed the first one.

@aSpite
Copy link
Contributor

aSpite commented Jan 9, 2024

@reveloper, hi, I would like to complete this task.

@reveloper
Copy link
Contributor Author

@aSpite
Awesome! Can you say the approximate release date?

@delovoyhomie, please assign this task.

@aSpite
Copy link
Contributor

aSpite commented Jan 10, 2024

@reveloper
2 weeks

@aSpite
Copy link
Contributor

aSpite commented Jan 24, 2024

@reveloper,

Hi, everything is ready:

  1. PR in fireworks-func
  2. PR in docs

@delovoyhomie
Copy link
Collaborator

Rewards Sent! Thank you for the contribution.

Qustbook proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This proposal is approved by the committee Education Related to educational resources or initiatives
Projects
None yet
Development

No branches or pull requests

3 participants