Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic metadata to custom TAFs (Series/Episode/ImageURL) #188

Open
SciLor opened this issue Jun 17, 2024 · 3 comments
Open

Add basic metadata to custom TAFs (Series/Episode/ImageURL) #188

SciLor opened this issue Jun 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@SciLor
Copy link
Contributor

SciLor commented Jun 17, 2024

The TAF-Header has 4096 bytes of usable data, only a fraction is used currently. So there is space to add some basic metadata.

This is already done for encoding purposes:
https://github.com/toniebox-reverse-engineering/teddycloud/blob/master/proto/toniebox.pb.taf-header.proto

@SciLor SciLor added the enhancement New feature or request label Jun 17, 2024
@henryk86
Copy link
Collaborator

henryk86 commented Jun 30, 2024

Tracks as string-array should also be added. And maybe for the teddycloud audioplayer the track-starting times in seconds as array

@g3gg0
Copy link
Collaborator

g3gg0 commented Jun 30, 2024

Yep, we had this in mind also.
However if done peoperly (in protobuf stream), it will most likely cause more memory usage.
Is this working with all stock firmware revisions?

If put behind protobuf data, it was unclear if it would cause other issues due to nonconformance.

Did you do some tests?

@cloud74pebble
Copy link

Maybe a custom.audio.json could help to manage the taf files.
I currently use the custom.tonies.json to make the tafs look more beautiful in the web-if.
An additional json-file would keep the custom.tonies.json cleaner...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants