Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Reset Tonie to Default vie WEBUI After Testing Web Radio #235

Open
Gummibaer opened this issue Nov 1, 2024 · 8 comments
Open
Labels
enhancement New feature or request fixed in develop

Comments

@Gummibaer
Copy link

After testing the Web Radio feature on a Tonie, I attempted to reset the Tonie back to its default settings. Simply deleting the URL did not work, and clicking the "X" to remove it had no effect either. Each time I clicked "Edit," the Web Radio reappeared.

To resolve this issue, I had to manually reset the Tonie by editing its JSON configuration. This process was not intuitive and could be streamlined to improve user experience.

Steps to Reproduce:

  • Select a Tonie and test the Web Radio feature.
  • Attempt to reset the Tonie to default settings by deleting the URL.
  • Click the "X" to remove the Web Radio.
  • Click "Edit" and observe that the Web Radio is still present.

Expected Behavior:

The Tonie should be able to return to its default state without needing to manually edit the JSON.

Actual Behavior:

The Web Radio remains active despite attempts to remove it through the interface.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 2, 2024

overworked the edit form.

X was initially only to revert any unsaved changes. now X clears the input. A new button is added which does the rollback.

image

If i clear the source field, the json is also adapted?

@Gummibaer
Copy link
Author

After clearing the source field and saving, the optional field remains filled. When you click on "Edit" again, the last radio station is still displayed.

Steps to Reproduce:

  • Edit Tonie and add a station
  • Save
  • Edit again and empty Source Field and save
  • Edit again optional field remains filled
  • refresh webui and Live Icon show in red
  • after disable optional field is empty

Add a station + Clear Source Field + Save
image

WebGUI
image
Json

{
	"live":	true,
	"nocloud":	false,
	"source":	"",
	"skip_seconds":	0,
	"cache":	false,
	"cloud_ruid":	"xxxxxx",
	"cloud_auth":	"xxxxxxx",
	"cloud_override":	false,
	"tonie_model":	"09-0001",
	"hide":	false,
	"claimed":	false,
	"_version":	5
}

after refresh webui
image

  • disable live

image

@henryk86
Copy link
Collaborator

henryk86 commented Nov 2, 2024

thats only a searchfield. its not related to any stored field.

@Gummibaer
Copy link
Author

However, the behavior where it is not immediately activated live after setting is definitely a bug, even if it's not critical. "No Cloud" is activated, but if you are just testing, you may not reload the page.

After removing it, when it should revert to the default, both "No Cloud" and "Live" should return to false.
I can't say how it looks when content is converted to the library, but it seems likely that the content would need to be reassigned manually anyway.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 2, 2024

I clear now the field if the edit dialog is opened.

Set it to live is not totally clear. sometimes the user has to use his brain.

resetting the cloud and live flag is not so easy. it could be done if the tag was an original one, but if it was a custom one, that would not be good. I will think about that.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 2, 2024

However, the behavior where it is not immediately activated live after setting is definitely a bug, even if it's not critical. "No Cloud" is activated, but if you are just testing, you may not reload the page.

I adapted the live setting accordingly. If the new source starts with "http" it's most likely a stream. In this case the live flag is set. If it's not starting with "http", I remove the live flag.

Removing the nocloud flag is not easily possible as said before. so i leave that as it is if it was enabled once.

@Gummibaer
Copy link
Author

image
TeddyCloud: v0.6.2 (203f12d) (Linux Docker on x86_64 KVM)
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36

Live flag is set, but not showing in WebUI.
After refresh (F5) it showing up.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 2, 2024

there is some action happening in the backend obviously... but this should be now fixed (at least in my develop branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in develop
Projects
None yet
Development

No branches or pull requests

2 participants