Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a URL path prefix #245

Open
mrueg opened this issue Nov 6, 2024 · 4 comments
Open

Support a URL path prefix #245

mrueg opened this issue Nov 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@mrueg
Copy link
Contributor

mrueg commented Nov 6, 2024

As of now, teddycloud and teddycloud_web assume that it runs directly on the root level at ip:port/

it would be nice if there was support for a path prefix (e.g. ip:port/teddycloud/), so it will be easier to run it behind a reverse proxy.

My workaround right now is filtering the javascript and html https://github.com/mrueg/addon-teddycloud/blob/main/teddycloud/rootfs/etc/nginx/servers/ingress.conf#L20 which is not ideal, as things change in teddycloud_web from time to time.

@SciLor SciLor added the enhancement New feature or request label Nov 6, 2024
@henryk86
Copy link
Collaborator

henryk86 commented Nov 7, 2024

have you tried to adapt the host url in the settings?

@mrueg
Copy link
Contributor Author

mrueg commented Nov 7, 2024

I have not, I'll give it a shot.
Does the host url have an effect on the minimized js if there's a prefix?

@henryk86
Copy link
Collaborator

henryk86 commented Nov 7, 2024

i dont know, was just a thought

@mrueg
Copy link
Contributor Author

mrueg commented Nov 7, 2024

I tested it, at least I couldn't see any difference. :/

I'm not a frontend dev, but could we use https://vite-plugin-ssr.com/base-url and have it injected by teddycloud into the embedded JS during runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants