Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ButtonGroup #54

Open
jerembdn opened this issue Nov 28, 2022 · 3 comments
Open

Add ButtonGroup #54

jerembdn opened this issue Nov 28, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jerembdn
Copy link
Member

  • Set the size and variant of all buttons within it.
  • Add spacing between the buttons.
  • Flush the buttons together by removing the border radius of their children as needed
@jerembdn jerembdn added the enhancement New feature or request label Nov 28, 2022
@jerembdn jerembdn moved this to 🆕 New in Kitchen Plan Nov 28, 2022
@AntoineKM
Copy link
Member

Add spacing between the buttons.

Container are fine for it.

The idea is good but it is still very complicated to implement and we may encounter some bugs, I lower the priority and put it on "low".

@AntoineKM AntoineKM moved this from 🆕 New to 📋 Backlog in Kitchen Plan Nov 30, 2022
@jerembdn
Copy link
Member Author

The goal of this group container is to assign the same props to every buttons within it like this, i think it could be great to have that feature, not only for tonightpass, but as a complete ui-kit.

<ButtonGroup variant='outline'>
  <Button color='blue'>Save</Button>
  <Button>Cancel</Button>
</ButtonGroup>

@YounesBessa YounesBessa moved this from 📋 Backlog to 🆕 New in Kitchen Plan Mar 6, 2023
@YounesBessa YounesBessa moved this from 🆕 New to 🔖 Ready in Kitchen Plan Mar 6, 2023
@AntoineKM AntoineKM added the good first issue Good for newcomers label Apr 2, 2023
@AntoineKM
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants