Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade clj/cljs version and remove parse-long warning. #38

Open
tlonist-sang opened this issue Dec 20, 2023 · 2 comments
Open

upgrade clj/cljs version and remove parse-long warning. #38

tlonist-sang opened this issue Dec 20, 2023 · 2 comments

Comments

@tlonist-sang
Copy link

; Warnings in Library Code:
;  parse-long already refers to: cljs.core/parse-long being replaced by: no.en.core/parse-long
;  parse-double already refers to: cljs.core/parse-double being replaced by: no.en.core/parse-double

Now that parse-long is inherently implemented in both clj/cljs (1.11, 1.11.50 onwards, repectively), the parse-long function need not be excluded. After upgrading clojure version,

(:refer-clojure :exclude [parse-long])

This line should be removed.

@tlonist-sang
Copy link
Author

tlonist-sang commented Dec 21, 2023

ah, this was already mentioned in #36. But the warnings persist with 0.4.4?
Do you plan to bump clojure/clojurescript to ver.11?

@tonsky
Copy link
Owner

tonsky commented Dec 27, 2023

I don’t see a warning neither in Clojure nor CLJS. It is set up this way so it would work with both old and new versions of Clojure. You suggest to change it so it only works with new ones. Why? What will we be getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants