Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Ranged weaponskills can proc double/triple/etc. attack. #2696

Open
3 tasks done
almuth150 opened this issue Mar 6, 2021 · 0 comments
Open
3 tasks done

Ranged weaponskills can proc double/triple/etc. attack. #2696

almuth150 opened this issue Mar 6, 2021 · 0 comments

Comments

@almuth150
Copy link

Additional Information (Steps to reproduce/Expected behavior) :
I noticed that sometimes when you use a ranged WS, you can get weird damage/tp returns, so I did a bit of digging. In weaponskills.lua, the function doRangedWeaponskill calls upon calculateRawWSDmg, which calls upon getMultiAttacks. That last function is always called, and has no check for whether or not it's a ranged weaponskill. This should not be the case; ranged weaponskills should not get any extra hits from those traits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant