Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: update cargo files to use workspace package #430

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: update cargo files to use workspace package #430

wants to merge 1 commit into from

Conversation

Freyskeyd
Copy link
Member

Description

This PR updates Cargo.toml files to use workspace value instead of redefining the same value in each crate.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested review from Nashtare and a team as code owners January 16, 2024 13:50
gruberb
gruberb approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fb4003) 66.95% compared to head (e0fadef) 68.99%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   66.95%   68.99%   +2.03%     
==========================================
  Files         220      220              
  Lines       12109    12109              
==========================================
+ Hits         8107     8354     +247     
+ Misses       4002     3755     -247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd
Copy link
Member Author

cargo-readme isn't compatible yet with workspace inheritance...

@dvdplm
Copy link
Contributor

dvdplm commented Jan 16, 2024

Hmm, why is CI trying to parse the README as toml? @Freyskeyd

@Freyskeyd
Copy link
Member Author

Freyskeyd commented Jan 16, 2024 •
edited
Loading

Hmm, why is CI trying to parse the README as toml? @Freyskeyd

it is part of how cargo-readme works, it reads the Cargo.toml to extract relevant data

@dvdplm
Copy link
Contributor

dvdplm commented Jan 23, 2024

@Freyskeyd Can we move this PR to draft status while waiting for cargo-readme to fix the issue?

@dvdplm dvdplm marked this pull request as draft January 23, 2024 11:54
@dvdplm
Copy link
Contributor

dvdplm commented Feb 21, 2024

@Freyskeyd Is cargo-readme fixed now you reckon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@gruberb gruberb gruberb approved these changes

@dvdplm dvdplm dvdplm approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Freyskeyd @dvdplm @gruberb @Nashtare