Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Delete button does not have a description #334

Open
EntityPlantt opened this issue Jan 28, 2023 · 5 comments · May be fixed by #338
Open

The Delete button does not have a description #334

EntityPlantt opened this issue Jan 28, 2023 · 5 comments · May be fixed by #338
Labels
bug good first issue Good for newcomers

Comments

@EntityPlantt
Copy link

image

The Delete button does not have a description.
@konstrybakov
Copy link
Contributor

Hi @EntityPlantt, thanks for taking the time to open this issue! Feel free to open a PR with your suggestions!

@wesbos
Copy link
Contributor

wesbos commented Jan 30, 2023

I think this is a bug @konstrybakov - the delete key has a description but isn't being displayed: https://github.com/toptal/keycodes/blob/main/lib/keycodes/with-events.ts#L340

Same goes for the keys, PageUp, PageDown, End, Home, NumPad Equals, and probably a few more.

@konstrybakov konstrybakov added bug good first issue Good for newcomers labels Jan 30, 2023
@konstrybakov
Copy link
Contributor

konstrybakov commented Feb 1, 2023 •
edited
Loading

Hey, @EntityPlantt, thank you for bringing this to our attention. I've marked this as a bug and we will place it in our backlog. However, even though it is a bug, we are open to contributions!

This 👇 shows the description though, so something is definitely wrong
https://www.toptal.com/developers/keycode/delete

Some strange behavior there 🪄

@EntityPlantt
Copy link
Author

Thanks for looking into the bug.

@wesbos wesbos linked a pull request Feb 1, 2023 that will close this issue
Open
@wesbos
Copy link
Contributor

wesbos commented Feb 1, 2023

I fixed it #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modify getKeyCodeEvent to match better. Fixes 336 wesbos/keycodes
3 participants
@wesbos @konstrybakov @EntityPlantt