Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: unknown unstable option: profile running coverage report workflow #1075

Closed
josecelano opened this issue Nov 5, 2024 · 4 comments · Fixed by #1086 or #1088
Closed

Error: unknown unstable option: profile running coverage report workflow #1075

josecelano opened this issue Nov 5, 2024 · 4 comments · Fixed by #1086 or #1088
Assignees
Labels
- Developer - Torrust Improvement Experience Bug Incorrect Behavior Continuous Integration Workflows and Automation

Comments

@josecelano
Copy link
Member

Run cargo check --tests --benches --examples --workspace --all-targets --all-features
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc - --crate-name ___ --print=file-names -Z profile -C codegen-units=1 -C opt-level=0 -C link-dead-code -C overflow-checks=off -Z panic_abort_tests -C panic=abort --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
  --- stderr
  error: unknown unstable option: `profile`

Error: Process completed with exit code 101.
@josecelano josecelano added Bug Incorrect Behavior Continuous Integration Workflows and Automation - Developer - Torrust Improvement Experience labels Nov 5, 2024
@josecelano josecelano self-assigned this Nov 5, 2024
@josecelano
Copy link
Member Author

josecelano commented Nov 5, 2024

The Rust flag profile was removed:

Now we have to generate the coverage report with "source-based coverage"

mozilla/grcov#1240 (comment)

I don't know how to use the alekitto/[email protected] action to generate the "source-based coverage". The actions doesn't look active. I think it's not possible.

I've tried to generate the report manually without using the alekitto/[email protected] action.

I have generated the report with:

cargo llvm-cov --lcov --output-path=./.coverage/lcov.info

And then, I've tried to upload it with codecov/codecov-action@v4 action, but it doesn't work, the action didn't complain but there is no coverage info on codecov

image

@josecelano
Copy link
Member Author

We have to change the way we generate the coverage report. I have created a sample project: codecov/codecov-action#1508 (comment)

cc @da2ce7

@josecelano
Copy link
Member Author

We have to change the way we generate the coverage report. I have created a sample project: codecov/codecov-action#1508 (comment)

cc @da2ce7

The example repo: https://github.com/josecelano-test/pull_request_target

josecelano added a commit to josecelano/torrust-tracker that referenced this issue Nov 15, 2024
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Nov 15, 2024
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Nov 15, 2024
@josecelano josecelano linked a pull request Nov 15, 2024 that will close this issue
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Nov 15, 2024
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Nov 15, 2024
josecelano added a commit that referenced this issue Nov 15, 2024
9d8174d ci: [#1075] fix coverage report (Jose Celano)
4dd6659 ci: [#1075] remove current coverage workflow (Jose Celano)

Pull request description:

  Fix coverage report workflow.

ACKs for top commit:
  josecelano:
    ACK 9d8174d

Tree-SHA512: da06fd95233b7accfff0d9e56dfd7b0beeff915696f740e146c79864af3ba8e199d54b74586444bbbeaa39bc43995a0464e2595b1fab85f3feea94960c30d08f
@josecelano
Copy link
Member Author

The new workflow only works for PRs. I have to recover the previous version for push events.

@josecelano josecelano reopened this Nov 15, 2024
@josecelano josecelano linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Bug Incorrect Behavior Continuous Integration Workflows and Automation
Projects
None yet
1 participant