Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubVerifierType installed ignored #12

Closed
simonmcl opened this issue Jul 20, 2021 · 1 comment
Closed

SubVerifierType installed ignored #12

simonmcl opened this issue Jul 20, 2021 · 1 comment

Comments

@simonmcl
Copy link

I thought setting the SubVerifierType of .installed meant it would check if the Twitter app was installed, or Reddit, or Facebook etc. It just seems to be ignored with no errors or warnings.

Looking through the code it looks like its only implemented inside the Google handler. Is this by design, is it only possible with google, or is this a missing feature?

If its a google-only feature, then it shouldn't be possible to assign .installed to the rest as its just confusing and messy

@metallicalfa2
Copy link
Contributor

Yes. Google OAuth allows to create web, iOS and android specific applications. Hence the .installed parameter. And it is only valid for google.
I will add the validation for to reject in other cases. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants