Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topupHide does not hide the "Please top up your wallet" in the transaction modal #547

Open
dnna opened this issue Feb 25, 2023 · 2 comments

Comments

@dnna
Copy link

dnna commented Feb 25, 2023

Describe the bug
I init torus with the following code, that I would expect to disable the topup functionality:

await torus.init({
  network: {
    host: "https://rpc.bombchain.com",
    chainId: 2300,
    networkName: "BOMB Chain"
  },
  buildEnv: "production",
  enableLogging: true,
  whiteLabel: {
    theme: {
      isDark: true,
      colors: {},
    },
    logoDark: "https://raw.githubusercontent.com/bombmoney/bomb-assets/master/bomb-logo.png",
    logoLight: "https://raw.githubusercontent.com/bombmoney/bomb-assets/master/bomb-logo.png",
    topupHide: true,
    featuredBillboardHide: true,
    disclaimerHide: true,
  }
});

I then attempt to make a stake transaction for the wallet, which has no gas.

However, as seen in the screenshot below, the "Please top up your wallet" button still appears.

Clicking the button leads to an endless redirect loop that crashes the popup (which I would expect since its a custom chain, there is no native onramper to buy coins).

The ideal behavior here would be for the topup string to be hidden completely, since topupHide is true.

Screenshots
image

@chaitanyapotti
Copy link
Member

topupHide only hides the topup tab in the wallet popup.
This button in screenshot is because user doesn't have funds for paying gas fees

@dnna
Copy link
Author

dnna commented Jun 8, 2023

OK, but this leads to a broken loop then (since its a custom chain, topup doesn't make sense with it). I take it there is no way to hide it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants