Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: deriving private key will fail if index is larger than that of decryptedShares.length #146

Open
metalurgical opened this issue May 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@metalurgical
Copy link
Contributor

metalurgical commented May 19, 2024

Maximum index of decrypted shares should be used here instead of decryptedShares.length in order to get the correct kCombinations in all instances:

const allCombis = kCombinations(decryptedShares.length, minThreshold);

This is reproducible in the following scenario:

threshold = 3
decryptedShares.count = 3
indexes: [2,3,4]

kCombinations will not include a combination for [2,3,4]
@metalurgical metalurgical added the bug Something isn't working label May 19, 2024
@metalurgical metalurgical changed the title Bug: deriving private key will fail if nodeindex is larger than that of decryptedShares.length Bug: deriving private key will fail if index is larger than that of decryptedShares.length May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant