Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit method -> selector mapping #1

Open
toshok opened this issue Nov 5, 2011 · 0 comments
Open

audit method -> selector mapping #1

toshok opened this issue Nov 5, 2011 · 0 comments
Labels

Comments

@toshok
Copy link
Owner

toshok commented Nov 5, 2011

right now the api bindings have been essentially generated by a little piece of elisp. there are some serious problems, where :'s have been left in method names which cause incorrect JS to be generated (coffeescript's compiler is fine with this, so there's no error.)

there are other less serious problems, though. many selectors come in pairs like:

-foo
-setFoo:

those should be converted to @instanceProperty/@staticProperty so that we get getter/setters in JS as opposed to methods.

and there are other methods that look like:

-doFooWithBarAndBaz: @nativeSelector("doFoo:withBar:andBaz:")

the method name should either be "do" or "doFoo". There is some leeway here wrt what the other methods in the class look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant