-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setRole.ts Error #2
Comments
Video if GitHub link not working. |
Is this still happening to you? |
Closing due to inactivity, feel free to re-open. |
This is still a reoccurring issue. Perhaps if this was replicated rather than passing it on, would've been a better solution? |
As far as I understand, the current code parses an integer which means that it fetches the group rank's ID. This should be changed into fetching the rank name instead as it's apparently possible to have two ranks with the same ID. |
I feel that the closure of this issue was justified, stale issues should not be kept open. Thanks for indicating that this still happens to you, though, we'll look into it. |
Rank names can also be the same, so there is really no way around this. We can most likely include a notice somewhere to make sure that users do not have same IDs for their ranks. But, I will leave this to the developer responsible for this section. |
|
What needs to be fixed:
Line 29
https://github.com/tovyblox/tovy/blob/main/pages/api/workspace/%5Bid%5D/settings/activity/setRole.ts
Role list from video shown, appears to be returning IDs from Group Role names. Apparently it's possible to have duplicate role IDs for different roles, which I find hard to believe, but the error says otherwise.
Error:
Video:
https://user-images.githubusercontent.com/109313802/205474701-42f7c17d-8942-4264-8856-19d550e839a8.mov
The text was updated successfully, but these errors were encountered: