Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRole.ts Error #2

Open
louuca opened this issue Dec 4, 2022 · 9 comments
Open

setRole.ts Error #2

louuca opened this issue Dec 4, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@louuca
Copy link

louuca commented Dec 4, 2022

What needs to be fixed:

Line 29
https://github.com/tovyblox/tovy/blob/main/pages/api/workspace/%5Bid%5D/settings/activity/setRole.ts

Role list from video shown, appears to be returning IDs from Group Role names. Apparently it's possible to have duplicate role IDs for different roles, which I find hard to believe, but the error says otherwise.

Error:
image

Video:
https://user-images.githubusercontent.com/109313802/205474701-42f7c17d-8942-4264-8856-19d550e839a8.mov

@louuca
Copy link
Author

louuca commented Dec 4, 2022

@marinofranz
Copy link
Contributor

Is this still happening to you?

@marinofranz
Copy link
Contributor

Closing due to inactivity, feel free to re-open.

@louuca
Copy link
Author

louuca commented Dec 22, 2022

Closing due to inactivity, feel free to re-open.

This is still a reoccurring issue. Perhaps if this was replicated rather than passing it on, would've been a better solution?

@louuca
Copy link
Author

louuca commented Dec 22, 2022

As far as I understand, the current code parses an integer which means that it fetches the group rank's ID.

This should be changed into fetching the rank name instead as it's apparently possible to have two ranks with the same ID.

@louuca
Copy link
Author

louuca commented Dec 22, 2022

image

image

With these two having the same rank number/id, it causes conflict and Tovy may incorrectly choose the rank as shown in the video in the first post.

@marinofranz
Copy link
Contributor

Closing due to inactivity, feel free to re-open.

This is still a reoccurring issue. Perhaps if this was replicated rather than passing it on, would've been a better solution?

I feel that the closure of this issue was justified, stale issues should not be kept open. Thanks for indicating that this still happens to you, though, we'll look into it.

@marinofranz marinofranz reopened this Dec 22, 2022
@marinofranz
Copy link
Contributor

This should be changed into fetching the rank name instead as it's apparently possible to have two ranks with the same ID.

Rank names can also be the same, so there is really no way around this. We can most likely include a notice somewhere to make sure that users do not have same IDs for their ranks. But, I will leave this to the developer responsible for this section.

@marinofranz marinofranz added the bug Something isn't working label Dec 22, 2022
@7angr
Copy link
Contributor

7angr commented Dec 22, 2022

This should be changed into fetching the rank name instead as it's apparently possible to have two ranks with the same ID.

Rank names can also be the same, so there is really no way around this. We can most likely include a notice somewhere to make sure that users do not have same IDs for their ranks. But, I will leave this to the developer responsible for this section.

GET https://groups.roblox.com/v1/groups/groupId/roles provides a unique identifier for each role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants