Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

This should be a workspace and allow for more examples #5

Open
bsdinis opened this issue Feb 26, 2021 · 2 comments
Open

This should be a workspace and allow for more examples #5

bsdinis opened this issue Feb 26, 2021 · 2 comments

Comments

@bsdinis
Copy link

bsdinis commented Feb 26, 2021

In the current layout, it is impossible to build the project and run the two binaries.

I suggest moving to a workspace layout, similar to the following:

| - Cargo.toml
| - http
    | - client
        | - Cargo.toml
        | - src/main.rs
    | - server
        | - Cargo.toml
        | - src/main.rs

Adding another example would be trivial

@davidpdrsn
Copy link
Member

I'm not even sure this repo is still maintained. It's using very old versions of tokio and hyper.

@bsdinis
Copy link
Author

bsdinis commented Feb 27, 2021

Completely agree. I tried to bump the versions and make it compile, but I guess it's hopeless.

Then I second Issue #4, this repo should be archived and marked as deprecated. When you google tower server example rust (or something like this) this is one of the top results. It would be nice that people would know that this isn't an up-to-date example (even nicer if there were examples 😄 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants