-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish release without pin-project (with pin-project-lite) #742
Comments
FWIW recently |
Tower's master branch has breaking changes. So a new release would mean a new major. So first we have to decide on whether to merge other breaking PRs first. We already have an issue for that. Regarding pin-project, Tower 0.4.x depends on pin-project as
here. So a |
Thank you David and Michael. Would it be worth mentioning the use of |
I don’t think so. Cargo is gonna automatically pick the latest version of pin-project when you depend on tower and otherwise cargo update should do the trick. I’ll close this for now but feel free to ask if you have more questions. |
FWIW, this wasn't completed in one big fell swoop -- there's multiple PRs responsible -- but |
Version 0.4.13 still depends on
pin-project
. Butmaster
got rid of it, and usespin-project-lite
only - thank you.Unfortunately,
pin-project
pulls oldsyn 1.0.109
. Butaxum-core
->async-trait
usessyn 2.0.5
. That means longer build times...Output of
cargo hackerman explain syn
on https://github.com/peter-kehl/rusti :See also cargo hackerman.
Please, consider disecting out and having a
pin-project-lite
-only release. Otherwise take this as a big "+1" for #722.The text was updated successfully, but these errors were encountered: