Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a git pre-commit hook that ensures no structs or enums outside types.rs #129

Open
etosch opened this issue Jul 12, 2019 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@etosch
Copy link
Collaborator

etosch commented Jul 12, 2019

We want to enforce that types all live in <gamename>/src/types.rs. Need to write a small program to do this that we can run as a pre-commit hook.

This is a good issue for non-experts because it doesn't require knowledge of much of rust, or Toybox. A very rudimentary version could just grep through the file for structs and enums. This could put restrictions on comments. A more sophisticated version might actually parse in the rust file and to determine if we have structs of enums.

@etosch etosch added the good first issue Good for newcomers label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant