You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
This picture is about code from burn-core/backend.rs
As we can see from the editor (Rust Analyzer), the features like tchautodiff and so on are enabled (they are lighter than cuda-jitcandle which is not) with [feature] like this in Cargo.toml
Although it likely has no influence on the end users, it may have impact on contributors. For example, with tch feature actually on, contributors who do not care about burn-tch without libtorch configured will be blocked when running cargo clippy.
To Reproduce
(section not need)
Expected behavior
The features enabled in examples do not influence code in crate.
Screenshots
(put before)
Desktop (please complete the following information):
(unrelated)
Smartphone (please complete the following information):
(unrelated)
Describe the bug
This picture is about code from
burn-core/backend.rs
As we can see from the editor (Rust Analyzer), the features like
tch
autodiff
and so on are enabled (they are lighter thancuda-jit
candle
which is not) with[feature]
like this inCargo.toml
We can find features
tch
autodiff
are not enable bydefault
, but they are actually enabled. So do featurestrain
std
ndarray
andfusion
...Actually, they are enabled by
examples/text-classification
,examples/text-generation
and so on.Although it likely has no influence on the end users, it may have impact on contributors. For example, with
tch
feature actually on, contributors who do not care aboutburn-tch
withoutlibtorch
configured will be blocked when runningcargo clippy
.To Reproduce
(section not need)
Expected behavior
The features enabled in
examples
do not influence code incrate
.Screenshots
(put before)
Desktop (please complete the following information):
(unrelated)
Smartphone (please complete the following information):
(unrelated)
Additional context
This problem can be solve with required-features, but it's tedious to fix.
Here's an example to fix:
step 1. set required features
step 2. set
--features
for each example )I'd like to deal with this flaw, however, I'm not so familar with
cargo-xtask
. If this is considered worth fixing, I'll try.The text was updated successfully, but these errors were encountered: