Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take a picture #8

Open
Bobcadence opened this issue Jun 3, 2017 · 6 comments
Open

Take a picture #8

Bobcadence opened this issue Jun 3, 2017 · 6 comments

Comments

@Bobcadence
Copy link

Hello,

All my tried to use take picture command failed.
The log «an unexpected error occurred».
I am on a honor 5c with android 7.0 if it help.
I will available to test your fix ;-)

@tranquvis
Copy link
Owner

Hello Bobcadence,

I have the same issue on my device. I inspected the code again, but I could not find any bug.

The problem in my case is:
The camera must be opened before it can be used, which may take some time. This process does not succeed and times out.

Working with the diversity of cameras is really hard and fixing this bug may take a while.
I will see what I can do.

I definitely keep you up to date.

@tranquvis
Copy link
Owner

I got it working. It was a multithreading problem. Obviously google changed the camera apis which caused problems with the Handler.

Please test this fix:
Apk 1.1.1

@Bobcadence
Copy link
Author

Bobcadence commented Jun 4, 2017 via email

@tranquvis
Copy link
Owner

Disabling flash should work with my most recent commit.

The Problem with black pictures:
This is a device specific issue, since its working for me. Maybe the rendering or compression algorithm is not supported on your device. I am sure that many people have similar problems, because I faced a lot of them when I developed this module.
I'm not happy about this, but supporting take picture on all devices is a very time consuming process.
I have not the time and not the devices in order to test and fix this issue. (Sorry)

Would be great if someone contributes to the development. ;)

@Bobcadence
Copy link
Author

Bobcadence commented Jun 4, 2017 via email

@tranquvis
Copy link
Owner

The flash fix has not been not built so far and is not included in the apk, which I sent.

Thank you very much for your engagement and your offer. But the most elaborate work is development and you need features to test. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants