Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Add minio support (via endpoint_url) #28

Open
korpa opened this issue Sep 27, 2020 · 3 comments
Open

Add minio support (via endpoint_url) #28

korpa opened this issue Sep 27, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@korpa
Copy link

korpa commented Sep 27, 2020

I'd like to use minio instead of AWS S3. Sadly my Python knowhow is to bad to do it on my own. An example is provided by
https://docs.min.io/docs/how-to-use-aws-sdk-for-python-with-minio-server.html

@korpa korpa added the enhancement New feature or request label Sep 27, 2020
@Samira-El
Copy link
Contributor

hey, I'm not familiar with minio but we've recently added support for aws_endpoint_url, perhaps that would work for your case?

@dluftspring
Copy link

@Samira-El was also looking at this I think the only thing that needs to be added is some conditional logic when you instantiate the boto3 client. I think without setting verify=False it won't work. Additionally use_ssl may also have to be disabled at the client level. Happy to try contributing the feature but not sure how you'd want it done stylistically.

boto3.resource('s3', 
    endpoint_url='<endpoint_url>',
    aws_access_key_id='<key_id>',
    aws_secret_access_key='<access_key>',
    aws_session_token=None,
    verify=False
)

@dluftspring
Copy link

Ignore my comment above 😄 confirmed that this actually works on latest default branch as is. You can close this issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@korpa @dluftspring @Samira-El and others