Compatible versions

[l-vincent-l]

I try to run the latest version of feed-registry (commit: 8ff0a1d) and the latest release of transitland-datastore (commit: 48c6ad0ce746cabdd6fbd569e6153092bfcad7e5).
When I add a feed, I can upload a file, but than I have a error due to the fact that feed_versions is a has_many (https://github.com/transitland/feed-registry/blob/master/app/feed/model.js#L10), and transitland-datastore returns a null, it's incompatible.

It would be great to add to the documentation which version of transitland-datastore is compatible with feed-registry.

[drewda]

@l-vincent-l the latest versions of Feed Registry and Datastore are always tested against each other. The master branch in each should line up, as should the production branches.

We may of course have missed a bug.

I am unable to reproduce the error that you mention. Please provide more information on the steps that produced the error.

[l-vincent-l]

I can reproduce it running transitland-datastore with docker-compose up --build (I changed the app command to bundle exec foreman start), and running feed-registry with ember serve.
Than I add this feed https://download.data.public.lu/resources/horaires-et-arrets-des-transport-publics/20170328-141752/OpenData_20170327.zip

[drewda]

https://download.data.public.lu/resources/horaires-et-arrets-des-transport-publics/20170328-141752/OpenData_20170327.zip does not contain a GTFS feed. Transitland can only import GTFS feeds.

I'm unclear, how were you able to add this URL to your local copy of the Transitland Datastore?

[l-vincent-l]

Is there a more direct way to speak about it ? Like a slack or something ?

[drewda]

We intentionally do not have a Transitland Slack organization at this time--using Github issues is preferable, since it keeps a record for others.

That said, if you have questions and ideas that go beyond this particular error, please do feel free to write us at [email protected]

[l-vincent-l]

I finally took time to make something to work on this bug.
This gist : https://gist.github.com/l-vincent-l/5b4cd21b7edbc436313c4351007be8ae install & than run a clean transitland.
If I go to http://localhost:5100/feeds/new and try to add http://data.trilliumtransit.com/gtfs/route128corridor-ma-us/route128corridor-ma-us.zip I have this error :

parseFetchInfoErrors@http://localhost:5100/assets/feed-registry.js:5272:7
beforeModel/<@http://localhost:5100/assets/feed-registry.js:5684:16
tryCatch@http://localhost:5100/assets/vendor.js:67717:14
invokeCallback@http://localhost:5100/assets/vendor.js:67732:15
publish@http://localhost:5100/assets/vendor.js:67700:9
publishRejection@http://localhost:5100/assets/vendor.js:67634:5
@http://localhost:5100/assets/vendor.js:44058:7
Queue.prototype.invoke@http://localhost:5100/assets/vendor.js:11578:9
Queue.prototype.flush@http://localhost:5100/assets/vendor.js:11642:11
DeferredActionQueues.prototype.flush@http://localhost:5100/assets/vendor.js:11443:11
Backburner.prototype.end@http://localhost:5100/assets/vendor.js:10732:9
Backburner.prototype.run@http://localhost:5100/assets/vendor.js:10854:13
run@http://localhost:5100/assets/vendor.js:31695:12
ember$data$lib$adapters$rest$adapter$$RestAdapter<.ajax/</hash.success@http://localhost:5100/assets/vendor.js:86097:15
jQuery.Callbacks/fire@http://localhost:5100/assets/vendor.js:3353:10
jQuery.Callbacks/self.fireWith@http://localhost:5100/assets/vendor.js:3465:7
done@http://localhost:5100/assets/vendor.js:9519:5
.send/callback@http://localhost:5100/assets/vendor.js:9923:8

If I apply this diff :

diff --git a/app/feed/model.js b/app/feed/model.js
index 999f0a5..4cbbffe 100644
--- a/app/feed/model.js
+++ b/app/feed/model.js
@@ -7,7 +7,7 @@ var Feed = DS.Model.extend({
   operators: DS.hasMany('operator', {
     async: true
   }),
-  feed_versions: DS.hasMany('feed-version', { async: true }),
+  //feed_versions: DS.hasMany('feed-version', { async: true }),
   url: DS.attr('string'),
   feed_format: DS.attr('string'),
   license_name: DS.attr('string')

The error disappears.

This is the response of datastore.
As you can see the value of the field feed_versions is null, but hasMany doesn't support it.

So, the master of transit-land/feed-registry and transitland/transitland-datastore are not compatible.