Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ISO-639-2 name for language codes from ISO-639-1 #72

Closed
vitonsky opened this issue Jun 25, 2023 · 0 comments · Fixed by #82
Closed

Wrong ISO-639-2 name for language codes from ISO-639-1 #72

vitonsky opened this issue Jun 25, 2023 · 0 comments · Fixed by #82
Labels
bug Something isn't working
Milestone
Release 1.0

Comments

@vitonsky
Copy link
Contributor

Supported languages actually from ISO-639-1 list, but object contains codes named as ISO-639-2:

core/src/util/languages.ts

Line 40 in 1e88f09

export const isLanguageCodeISO639v2 = (language: string) => {

We have to fix name and add ISO-639-2 language codes from https://www.loc.gov/standards/iso639-2/php/code_list.php

Related link: translate-tools/linguist#374
@vitonsky vitonsky added the bug Something isn't working label Jun 25, 2023
@vitonsky vitonsky added this to the Release 0.3 milestone Jul 22, 2023
vitonsky added a commit that referenced this issue Jul 29, 2023
@vitonsky
feat(#72): add ISO639 1 and 2 codes
d05b312
vitonsky added a commit that referenced this issue Jul 29, 2023
@vitonsky
test(#72): fix tests
5de473b
@vitonsky vitonsky linked a pull request Jul 29, 2023 that will close this issue
Wrong ISO-639-2 name for language codes from ISO-639-1 #82
Merged
vitonsky added a commit that referenced this issue Jul 29, 2023
@vitonsky
fix(#72): cast type to boolean
9df4b7c
vitonsky added a commit that referenced this issue Jul 29, 2023
@vitonsky
test(#72): fix language code validation check
d3493b0
vitonsky added a commit that referenced this issue Jul 29, 2023
@vitonsky
test(#72): skip test valid languages
f7f6d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

Wrong ISO-639-2 name for language codes from ISO-639-1 translate-tools/core
1 participant
@vitonsky