Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppy dependencies not requiring @uppy/[email protected] missing emitSocketProgress #5557

Closed
2 tasks done
TheSeg opened this issue Dec 17, 2024 · 7 comments
Closed
2 tasks done
Labels

Comments

@TheSeg
Copy link

TheSeg commented Dec 17, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

In @uppy/[email protected], the emitSocketProgress file was removed. However, projects that refer to @uppy/companion-client are set to 4.2.0, which requires @uppy/utils/lib/emitSocketProgress[.ts] to exist, break the build.

Thus building the project with the following is not possible:

  • @uppy/transloadit
  • @uppy/uts @uppy/tus
  • @uppy/url

Expected behavior

All project dependencies are built to versions matching their support.

@uppy/transloadit, @uppy/uts, and @uppy/url should require @uppy/[email protected].

Actual behavior

@uppy/transloadit, @uppy/uts, and @uppy/url do not require @uppy/[email protected], and thus break due to missing emitSocketProgress file in @uppy/[email protected].

@TheSeg TheSeg added the Bug label Dec 17, 2024
@TheSeg
Copy link
Author

TheSeg commented Dec 17, 2024

A workaround is to manually add @uppy/companion-client to your project, thus forcing the update to your project. However this is not ideal as this is a dependency library, not intended to be directly installed.

@Murderlon
Copy link
Member

What versions are you using? If you are on latest versions this shouldn't happen.

What is @uppy/uts?

@TheSeg
Copy link
Author

TheSeg commented Dec 18, 2024

My apologies, I meant @uppy/tus!

This is the list I have defined now with Uppy, before explicitly adding @uppy/companion-client:

        "@uppy/compressor": "^2.1.1",
        "@uppy/core": "^4.3.1",
        "@uppy/dashboard": "^4.1.3",
        "@uppy/drag-drop": "^4.0.5",
        "@uppy/drop-target": "^3.0.2",
        "@uppy/file-input": "^4.0.4",
        "@uppy/image-editor": "^3.2.1",
        "@uppy/progress-bar": "^4.1.0",
        "@uppy/status-bar": "^4.0.6",
        "@uppy/transloadit": "^4.1.4",
        "@uppy/url": "^4.1.2",
        "@uppy/vue": "^2.0.3",

The problem is that @uppy/transloadit, @uppy/tus, and @uppy/url each have the dependency of "@uppy/companion-client": "^4.2.0". But that is now false as that version breaks.

@AaronPorts
Copy link

@TheSeg delete package-lock and node_modules, reinstall dependencies

@Murderlon
Copy link
Member

@TheSeg can you check if that helps?

@AaronPorts
Copy link

AaronPorts commented Dec 24, 2024

@Murderlon seems like some npm packages have outdated dependencies. For ex. @uppy/xhr-upload 4.2.3 has "@uppy/companion-client": "^4.2.0" instead 4.3.0 and "@uppy/utils": "^6.0.5" instead 6.0.6. This breaks the installation. not breaks, everything is fine after clean reinstall.
npm 11.0.0
@uppy/aws-s3": "^4.1.3,
@uppy/compressor": "^2.1.1,
@uppy/core": "^4.3.1,
@uppy/drag-drop": "^4.0.5,
@uppy/react": "^4.0.4,
@uppy/xhr-upload": "^4.2.3,

@Murderlon
Copy link
Member

Reopening if there's further proof this break after clean install.

@Murderlon Murderlon closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants