Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Enhance Pagination Experience on Newsfeed Page #182

Open
4 tasks
Uchechukwu-Onye-Igbo opened this issue Oct 31, 2024 · 10 comments
Open
4 tasks
Assignees

Comments

@Uchechukwu-Onye-Igbo
Copy link

Uchechukwu-Onye-Igbo commented Oct 31, 2024

When browsing the newsfeed on the TDC portal, I want a smooth and responsive pagination experience, so that I can easily navigate through updates without lag or confusion and focus on the content.

Tasklist (TBD - updated by the developer)

  • [add tasks]

Acceptance Criteria

Given that I am navigating content on the newsfeed page,

  • when i am using the pagination implementation on the page, i should see all relevant content based on the category i select
  • i can navigate the page smoothly by clicking on the page numbers and the direction arrows.
  • I want my browser to only load the data that is necessary for what is currently visible on the screen so that I can use the page as soon as possible
  • I want to be able to navigate the entire activity history, regardless of when the activity happened
@Uchechukwu-Onye-Igbo
Copy link
Author

Hello @Gutts-n if you have reviewed this implementation, kindly update it to the right status. thank you

@Gutts-n
Copy link
Contributor

Gutts-n commented Nov 5, 2024

@willy1989cv

  • Implement integration tests
  • Fix filter sort of the page (probably frontend work)
  • Validate and fix if any of the filters is limiting just to the data available for the user who is searching, not to return activities from other users
  • Add a skeleton while loading the data on the page

cc: @Uchechukwu-Onye-Igbo

@nicolas-becker
Copy link
Contributor

I was pointed here by @willy1989cv to flag the following issue:

The username of the user whose permission rights were changed is not displayed in the notification:
image

@Uchechukwu-Onye-Igbo
Copy link
Author

I was pointed here by @willy1989cv to flag the following issue:

The username of the user whose permission rights were changed is not displayed in the notification: image

hello @Gutts-n please take a look at this comment

@Gutts-n
Copy link
Contributor

Gutts-n commented Nov 12, 2024

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

@Gutts-n
Copy link
Contributor

Gutts-n commented Nov 12, 2024

@nicolas-becker
Copy link
Contributor

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

@Gutts-n The notifcation "You updated the user" should contain at least the name of the user. So in this case "You updated the user vvilly89". Better would be of course if the notification contained the full information that I updated the user from member to editor for organizationX.

You should be able te reproduce the error if you change a member's permission rights for an organization you are admin of.

@Uchechukwu-Onye-Igbo
Copy link
Author

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

@Gutts-n The notifcation "You updated the user" should contain at least the name of the user. So in this case "You updated the user vvilly89". Better would be of course if the notification contained the full information that I updated the user from member to editor for organizationX.

You should be able te reproduce the error if you change a member's permission rights for an organization you are admin of.

hello @Gutts-n please take a look at this comment

@Gutts-n
Copy link
Contributor

Gutts-n commented Nov 14, 2024

@Uchechukwu-Onye-Igbo, I think @willy1989cv is looking at it. We agreed via chat some days ago that he would fix this.

@willy1989cv if you aren't looking, please let me know.

@willy1989cv
Copy link
Contributor

@Gutts-n yes, I am looking at it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants