-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed schema changes #20
Comments
@jpolka can you make a pull request with your edits to the schema. Do not merge it, but once i have the commit I can take it from there. This will be the first time we are changing the schema after there are already some annotations. Here's the computational workflow I'm envisioning:
This means that any changes to to the RoMEO fields will get overwritten.
Sounds reasonable to me!
I will see what's possible here given the treacherous documentation and attitude of
If you did this, then I we wouldn't have to worry about section headers, and I could easily remove the newlines (which took me a very long time to add, but if they are more damaging then helpful, we should remove). |
@jpolka IIRC you also mentioned the idea of adding a general comments field somewhere? |
Can we use \n for new lines in descriptions?
Yes, I will add this too! |
Closes transpose-publishing#27 refs transpose-publishing#20 Contains squashed commits from transpose-publishing#27
Closes transpose-publishing#27 refs transpose-publishing#20 Contains squashed commits from transpose-publishing#27
As per the discussion on Gitter with @cameronblandford, it would be good to add the following changes: (Please also suggest different tags for the field, @tonyR-H ?) field
type: seq
desc: "Field - add all that apply. Add a new line for each. Start each line with two spaces, a dash, and one space, like this: ' - ' (biology/chemistry/physics/computer science/medicine/math/social science/humanities)"
sequence:
- type: str
enum: [the above] #Not sure this will work - http://www.kuwata-lab.com/kwalify/ruby/users-guide.01.html#schema
visible
type: str
desc: "Used by moderators to determine whether record is shown in frontend (yes/no) - do not edit
enum: [yes, no] |
Regarding the
The website should link to the source YAML file on GitHub which has a blame view. We could also calculate contribution summaries based on the git history for each YAML file.
Currently, at http://transpose.surge.sh I don't see actual data (I think it's showing mock data, BTW awesome design @cameronblandford ). An alternative to a visible field would be to only display fields that are not |
@dhimmel surge.sh only hosts static sites, so I haven't been able to provide updates to that deployment for any of the more recent changes. I'll put up something today. Only displaying fields that aren't null is already implemented in the dynamic version 👍 Thinking about it more now, I think it would be even better to display every policy regardless of how much has been filled out, and then have a link to the relevant file in the repo for each policy somewhere on the policy detail page, in a sort of "Contribute to this policy's collected information here" way. |
That way users can easily see where and how they can contribute, and contribute to areas that interest them.
|
This discussion sounds good! Re fields - while I think a tag system would permit more flexibility (especially for interdisciplinary journal) than a system of categories, I completely agree with your point about using existing data where possible! It does seem like BTW I just noticed these little typos we might want to fix next time around...
|
From the editathon -
Also: Should be
|
@jpolka can you make a PR that modifies the schema according to the edithon points? Then I can take it from there? |
@dhimmel, absolutely, will do. However I am now also finding myself wanting a way to track: Are [X] published? [mandatory/optional/conditional/no]
Where X is:
I think @tonyR-H has some other wishes as well. |
I don't see a kwalify option for conditional or dependent fields. Therefore, I don't think we can make the schema only allow setting "who decides" if the field is set to optional or conditional. However, we could always ignore the contents of "who decides" in those cases at a later stage. We can still have comments letting users know to fill in the field if optional or conditional is set. The following three categories make sense with the above fields:
I am not sure what "Previous versions of the manuscript" means in this context and I don't think all of the fields above apply to "Reviewer identities". Other comments: what is "DOI ontology"? What do you mean by "DOI Type"? Is this for the DOI registrar agency, e.g. Crossref, Datacite, ...? |
Thanks @dhimmel - I mean whether all the review files and kept together in one DOI or whether each reviewer report/author response/decision letter has its own DOI Crossref peer review DOI type. Good point about just ignoring input for "who decides" when it is not applicable. I think this is a reasonable approach regardless of whether we switch platforms to something that permits conditional responses, as discussed in #36. |
Here are some suggested changes/additions!
The text was updated successfully, but these errors were encountered: