scribe_tail infinite loop #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scribe_tail was using the results from stat() rather than fstat() to detect file truncation, resulting in a false positive when filename is changed to point to a new, empty file. scribe_tail would then rewind the open file (not filename) and replay the log repeatedly. This changes scribe_tail to use the results from fstat() on the open file to detect truncation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked down what I think was probably just a typo in scribe_tail's do_tail() that causes it to loop infinitely when the file it's tailing is rotated. The issue is described in the commit message, and it stems from using the stat size from the filename rather than the open file.
scribe_tail is otherwise very useful, thanks for sharing it.