New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo #4

Open

themathmagician opened this issue Nov 9, 2021 · 1 comment

themathmagician commented Nov 9, 2021

proglog/ServerSideServiceDiscovery/internal/discovery/membership.go

Line 42 in f6dae5f

addr, err := net.ResolveTCPAddr("tcp", m.BindAddr)

This code won't compile. Should be: m.Config.BindAddress

cschar commented Jul 30, 2023

typo in DeployLocally section: in Dockerfile https://github.com/travisjeffery/proglog/blob/master/DeployLocally/Dockerfile#L11C4-L11C75

we have https:#github , also no space after -qO, fixed as

RUN GRPC_HEALTH_PROBE_VERSION=v0.3.2 && \
    wget -q -O /go/bin/grpc_health_probe \
    https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \
    chmod +x /go/bin/grpc_health_probe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment