Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_client and http_server docs about their metadata is wrong #246

Open
mfelsche opened this issue Sep 30, 2022 · 0 comments
Open

http_client and http_server docs about their metadata is wrong #246

mfelsche opened this issue Sep 30, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation hacktoberfest Hacktoberfest help wanted Extra attention is needed

Comments

@mfelsche
Copy link
Member

Both expect and emit metadata under $http_server or $http_client prefixes. The section about metadata https://www.tremor.rs/docs/0.12/reference/connectors/http#metadata needs an overhaul in that regard.

How the server handles response metadata under $http_server.response can be seen by following this piece of code: https://github.com/tremor-rs/tremor-runtime/blob/main/src/connectors/impls/http/server.rs#L537
This is how the server represents request metadata underneath $http_server.request.

This is how the http_client connector extracts http request properties from the event metadata below $http_client.request: https://github.com/tremor-rs/tremor-runtime/blob/main/src/connectors/impls/http/meta.rs#L55
This is how the http_client connector represents response data under $http_client.response: https://github.com/tremor-rs/tremor-runtime/blob/main/src/connectors/impls/http/meta.rs#L315-L321

@mfelsche mfelsche added documentation Improvements or additions to documentation help wanted Extra attention is needed hacktoberfest Hacktoberfest labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant