Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The timeFilter macro uses local time instead of UTC #264

Open
stefan-toubia opened this issue Oct 1, 2024 · 0 comments · May be fixed by #265
Open

The timeFilter macro uses local time instead of UTC #264

stefan-toubia opened this issue Oct 1, 2024 · 0 comments · May be fixed by #265

Comments

@stefan-toubia
Copy link
Member

The timeFilter macro doesn't normalize timestamps to UTC, unlike all the other macros

grafana-trino/pkg/trino/macros.go

Lines 86 to 87 in 80215f4

from = query.TimeRange.From.Format(goTimestampFormat)
to = query.TimeRange.To.Format(goTimestampFormat)

I noticed this while running Grafana on my local machine, not in UTC.
@stefan-toubia stefan-toubia linked a pull request Oct 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use UTC timestamps in macroTimeFilter stefan-toubia/grafana-trino
1 participant
@stefan-toubia