Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for failing Codecov runs #1905

Closed
ranocha opened this issue Apr 15, 2024 · 5 comments
Closed

Workaround for failing Codecov runs #1905

ranocha opened this issue Apr 15, 2024 · 5 comments
Labels
testing upstream

Comments

@ranocha
Copy link
Member

ranocha commented Apr 15, 2024

Xref codecov/feedback#301
@ranocha ranocha mentioned this issue May 19, 2024
Merged
3 tasks
@huiyuxie
Copy link
Member

Then how do you know a PR is ready to be merged with a always failing CI? @ranocha

@JoshuaLampert
Copy link
Member

We just have a look at the test reports. If all real tests pass, but only the step uploading the Codecov report fails because of precisely this issue, we (basically) know it's fine.

@JoshuaLampert
Copy link
Member

Or we rerun CI until Codecov is happy. Of course, this is not ideal.

@huiyuxie
Copy link
Member

Good. Hope this gets resolved soon.

This was referenced Nov 13, 2024
Closed
Merged
@JoshuaLampert JoshuaLampert mentioned this issue Dec 1, 2024
Merged
@JoshuaLampert
Copy link
Member

As I understand #2185 should fix this. I'll close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ranocha @JoshuaLampert @huiyuxie