Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programatic links decode plcaeholder #245

Open
ethan-oro opened this issue Oct 4, 2024 · 1 comment
Open

programatic links decode plcaeholder #245

ethan-oro opened this issue Oct 4, 2024 · 1 comment

Comments

@ethan-oro
Copy link

given the a link like

go/service-123/%s

that expands to

http://www.service123.com/pageA?param=%s

if i supply a url-encoded value (i.e. a timestamp 2024-09-30T17:46:38+00:00 encoded as 2024-09-30T17%3A46%3A38%2B00%3A00) so the link looks like

go/service-123/2024-09-30T17%3A46%3A38%2B00%3A00

when the link expands, the value has been url-decoded to

http://www.service123.com/pageA?param=2024-09-30T17:46:38+00:00

however, since the service expects a url-encoded timestamp, it fails.

the behavior i think would be good would be to either automatically url-encode all values, or at least make the incoming value equal to the outgoing one, like

http://www.service123.com/pathA?param=2024-09-30T17%3A46%3A38%2B00%3A00

@mreifman
Copy link

I've found this to be an issue when substituting email addresses like [email protected].

Using the above example, the URL-encoded go link go/service-123/foo%2Bbar%40foo.com gets redirected to http://www.service123.com/pageA?param=foo+bar%40foo.com: the @ stays URL-encoded but the plus sign does not. The service then gets the param value with a space instead of a plus sign: foo [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants