Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rewriteResponseBody as a middleware #15329

Closed
wants to merge 3 commits into from
Closed

Added rewriteResponseBody as a middleware #15329

wants to merge 3 commits into from

Conversation

RodoMa92
Copy link

@RodoMa92 RodoMa92 commented Nov 24, 2023 •
edited
Loading

Description
This add the requested feature #15328 to the best of my abilites, but it should be double checked for eventual mistakes. I've based this comparing the install procedure for kubernetes here and the already present rewrite headers in this repo and merged the two.

⚒️ Fixes #15328

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@RodoMa92 RodoMa92 requested review from PrivatePuffin and a team as code owners November 24, 2023 16:57
PrivatePuffin
PrivatePuffin requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version increase, missing values.yaml example, missing GUI component for SCALE.

@PrivatePuffin PrivatePuffin marked this pull request as draft November 24, 2023 17:00
@PrivatePuffin
Copy link
Member

Also is missing the actual plugin.
But i'm not in favor anyway, as this plugin isn't actively maintained.

@RodoMa92
Copy link
Author

There is also this fork available, does this might be a better fit? https://github.com/dirtycajunrice/subfilter

I'll keep looking around otherwise.

@RodoMa92
Copy link
Author

Yeah, even less updated, now that I look at it. I'll keep searching then.

@RodoMa92
Copy link
Author

Yeah, sadly I can't find any replacement for it. I might have a better look later.

@RodoMa92 RodoMa92 deleted the add-responsebody branch December 3, 2023 11:31
@RodoMa92 RodoMa92 restored the add-responsebody branch December 27, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrivatePuffin PrivatePuffin PrivatePuffin requested changes

@alfi0812 alfi0812 Awaiting requested review from alfi0812 alfi0812 will be requested when the pull request is marked ready for review alfi0812 is a code owner

@kqmaverick kqmaverick Awaiting requested review from kqmaverick kqmaverick will be requested when the pull request is marked ready for review kqmaverick is a code owner

@Heavybullets8 Heavybullets8 Awaiting requested review from Heavybullets8 Heavybullets8 will be requested when the pull request is marked ready for review Heavybullets8 is a code owner

@StevenMcElligott StevenMcElligott Awaiting requested review from StevenMcElligott StevenMcElligott will be requested when the pull request is marked ready for review StevenMcElligott is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RewriteBody to the Traefik middlewares
2 participants
@RodoMa92 @PrivatePuffin