Skip to content

Commit

Permalink
Technical/Update gem development dependencies (#220)
Browse files Browse the repository at this point in the history
* Updated gemspecs, circleci config
* Updated git templates
* Updated rubocop/codeclimate configs
* Updated version, docs, changelog
  • Loading branch information
bestwebua authored May 2, 2022
1 parent b7d69a6 commit f0d7026
Show file tree
Hide file tree
Showing 10 changed files with 58 additions and 23 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defaults: &defaults
- image: cimg/ruby:<< parameters.ruby-version >>

orbs:
ruby: circleci/ruby@1.4.0
ruby: circleci/ruby@1.7.1

references:
restore_bundle_cache: &restore_bundle_cache
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- checkout
- <<: *use_compatible_gemspec
- ruby/install-deps:
bundler-version: "2.3.8"
bundler-version: "2.3.12"
with-cache: false
path: './vendor/custom_bundle'
- <<: *install_system_dependencies
Expand Down
7 changes: 3 additions & 4 deletions .circleci/gemspec_compatible
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'

spec.add_development_dependency 'dns_mock', '~> 1.5'
spec.add_development_dependency 'ffaker', '~> 2.20'
spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.2'
spec.add_development_dependency 'ffaker', '~> 2.21'
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
spec.add_development_dependency 'pry-byebug', '~> 3.9'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'rspec', '~> 3.11'
spec.add_development_dependency 'smtp_mock', '~> 1.0'
spec.add_development_dependency 'smtp_mock', '~> 1.0', '>= 1.0.1'
spec.add_development_dependency 'truemail-rspec', '~> 0.9.1'
spec.add_development_dependency 'webmock', '~> 3.14'
end
18 changes: 9 additions & 9 deletions .circleci/gemspec_latest
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,20 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'

spec.add_development_dependency 'bundler-audit', '~> 0.9.0.1'
spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.1'
spec.add_development_dependency 'fasterer', '~> 0.9.0'
spec.add_development_dependency 'ffaker', '~> 2.20'
spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.2'
spec.add_development_dependency 'fasterer', '~> 0.10.0'
spec.add_development_dependency 'ffaker', '~> 2.21'
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
spec.add_development_dependency 'overcommit', '~> 0.58.0'
spec.add_development_dependency 'overcommit', '~> 0.59.0'
spec.add_development_dependency 'pry-byebug', '~> 3.9'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'reek', '~> 6.1'
spec.add_development_dependency 'reek', '~> 6.1', '>= 6.1.1'
spec.add_development_dependency 'rspec', '~> 3.11'
spec.add_development_dependency 'rubocop', '~> 1.25', '>= 1.25.1'
spec.add_development_dependency 'rubocop-performance', '~> 1.13', '>= 1.13.2'
spec.add_development_dependency 'rubocop-rspec', '~> 2.9'
spec.add_development_dependency 'rubocop', '~> 1.28', '>= 1.28.2'
spec.add_development_dependency 'rubocop-performance', '~> 1.13', '>= 1.13.3'
spec.add_development_dependency 'rubocop-rspec', '~> 2.10'
spec.add_development_dependency 'simplecov', '~> 0.21.2'
spec.add_development_dependency 'smtp_mock', '~> 1.0'
spec.add_development_dependency 'smtp_mock', '~> 1.0', '>= 1.0.1'
spec.add_development_dependency 'truemail-rspec', '~> 0.9.1'
spec.add_development_dependency 'webmock', '~> 3.14'
end
2 changes: 1 addition & 1 deletion .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ checks:
plugins:
rubocop:
enabled: true
channel: rubocop-1-25
channel: rubocop-1-28

reek:
enabled: true
2 changes: 1 addition & 1 deletion .github/DEVELOPMENT_ENVIRONMENT_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ cd truemail
Configure latest Ruby environment:

```bash
echo 'ruby-3.1.1' > .ruby-version
echo 'ruby-3.1.2' > .ruby-version
cp .circleci/gemspec_latest truemail.gemspec
```

Expand Down
27 changes: 27 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,18 @@ Style/FileWrite:
Style/MapToHash:
Enabled: true

Style/FetchEnvVar:
Enabled: true

Style/NestedFileDirname:
Enabled: true

Style/ObjectThen:
Enabled: true

Style/RedundantInitialize:
Enabled: true

Layout/LineLength:
Max: 140

Expand Down Expand Up @@ -368,6 +380,9 @@ Lint/RequireRelativeSelfPath:
Lint/UselessRuby2Keywords:
Enabled: true

Lint/RefinementImportMethods:
Enabled: true

Gemspec/DateAssignment:
Enabled: true

Expand All @@ -380,6 +395,9 @@ Gemspec/RubyVersionGlobalsUsage:
Security/IoMethods:
Enabled: true

Security/CompoundHash:
Enabled: true

Performance/AncestorsInclude:
Enabled: true

Expand Down Expand Up @@ -481,3 +499,12 @@ RSpec/FactoryBot/SyntaxMethods:

RSpec/SubjectStub:
Enabled: false

RSpec/BeEq:
Enabled: true

RSpec/BeNil:
Enabled: true

RSpec/VerifiedDoubleReference:
Enabled: false
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.7.2] - 2022.04.02

### Updated

- Updated gemspecs, circleci config
- Updated rubocop/codeclimate configs
- Updated git templates
- Updated gem version

## [2.7.1] - 2022.03.02

### Updated
Expand Down
2 changes: 1 addition & 1 deletion lib/truemail/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Truemail
VERSION = '2.7.1'
VERSION = '2.7.2'
end
4 changes: 2 additions & 2 deletions spec/truemail/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
expect(configuration_instance.default_validation_type).to eq(Truemail::Configuration::DEFAULT_VALIDATION_TYPE)
expect(configuration_instance.validation_type_by_domain).to eq({})
expect(configuration_instance.whitelisted_domains).to eq([])
expect(configuration_instance.whitelist_validation).to eq(false)
expect(configuration_instance.whitelist_validation).to be(false)
expect(configuration_instance.blacklisted_domains).to eq([])
expect(configuration_instance.blacklisted_mx_ip_addresses).to eq([])
expect(configuration_instance.dns).to eq([])
Expand All @@ -131,7 +131,7 @@
expect(configuration_instance.default_validation_type).to eq(Truemail::Configuration::DEFAULT_VALIDATION_TYPE)
expect(configuration_instance.validation_type_by_domain).to eq({})
expect(configuration_instance.whitelisted_domains).to eq([])
expect(configuration_instance.whitelist_validation).to eq(false)
expect(configuration_instance.whitelist_validation).to be(false)
expect(configuration_instance.blacklisted_domains).to eq([])
expect(configuration_instance.blacklisted_mx_ip_addresses).to eq([])
expect(configuration_instance.dns).to eq([])
Expand Down
6 changes: 3 additions & 3 deletions truemail.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'net-smtp', '~> 0.3.1' if ::RUBY_VERSION >= '3.1.0'
spec.add_runtime_dependency 'simpleidn', '~> 0.2.1'

spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.1'
spec.add_development_dependency 'ffaker', '~> 2.20'
spec.add_development_dependency 'dns_mock', '~> 1.5', '>= 1.5.2'
spec.add_development_dependency 'ffaker', '~> 2.21'
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'rspec', '~> 3.11'
spec.add_development_dependency 'smtp_mock', '~> 1.0'
spec.add_development_dependency 'smtp_mock', '~> 1.0', '>= 1.0.1'
spec.add_development_dependency 'truemail-rspec', '~> 0.9.1'
spec.add_development_dependency 'webmock', '~> 3.14'
end

0 comments on commit f0d7026

Please sign in to comment.