NAS-131093 / 25.04 / Remove EntityJobComponent #10733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/modules/terminal/terminal.module.ts # src/app/pages/account/account.module.ts # src/app/pages/account/groups/groups.module.ts # src/app/pages/account/users/users.module.ts # src/app/pages/api-keys/api-keys.module.ts # src/app/pages/credentials/credentials.module.ts # src/app/pages/data-protection/data-protection.module.ts # src/app/pages/datasets/modules/encryption/encryption.module.ts # src/app/pages/datasets/modules/snapshots/snapshots.module.ts # src/app/pages/directory-service/directory-service.module.ts # src/app/pages/jobs/jobs-list.module.ts # src/app/pages/network/network.module.ts # src/app/pages/services/services.module.ts # src/app/pages/sharing/sharing.module.ts # src/app/pages/shell/shell.module.ts # src/app/pages/storage/modules/devices/devices.module.ts # src/app/pages/storage/modules/disks/disks.module.ts # src/app/pages/system/system.module.ts # src/app/pages/vm/vm.module.ts
undsoft
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10733 +/- ##
==========================================
+ Coverage 80.28% 80.60% +0.32%
==========================================
Files 1571 1570 -1
Lines 51711 51509 -202
Branches 5840 5809 -31
==========================================
+ Hits 41518 41521 +3
+ Misses 10193 9988 -205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RehanY147
requested changes
Sep 25, 2024
|
Yeah, forgot to remove the most important thing. |
RehanY147
approved these changes
Sep 27, 2024
# Conflicts: # src/app/modules/entity/entity.module.ts # src/app/pages/account/account.module.ts # src/app/pages/datasets/modules/snapshots/snapshots.module.ts # src/app/pages/jobs/jobs-list.module.ts # src/app/pages/storage/storage.module.ts # src/app/pages/system/system.module.ts # src/app/pages/vm/vm.module.ts
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removes last usages of EntityJobComponent.
Testing:
Test affected places.